7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-09-23 20:54:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use isJust instead of reimplementing it

Browse Source
This commit is contained in:
Joseph C. Sible
2020-02-09 23:06:12 -05:00
parent 6d06103cab
commit d5c5128115
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ShellCheck/Checks/ShellSupport.hs
View File

@@ -456,11 +456,10 @@ checkEchoSed = ForShell [Bash, Ksh] f
-- This should have used backreferences, but TDFA doesn't support them -- This should have used backreferences, but TDFA doesn't support them
sedRe = mkRegex "^s(.)([^\n]*)g?$" sedRe = mkRegex "^s(.)([^\n]*)g?$"
isSimpleSed s = fromMaybe False $ do isSimpleSed s = isJust $ do
[h:_,rest] <- matchRegex sedRe s [h:_,rest] <- matchRegex sedRe s
let delimiters = filter (== h) rest let delimiters = filter (== h) rest
guard $ length delimiters == 2 guard $ length delimiters == 2
return True
checkIn id s = checkIn id s =
when (isSimpleSed s) $ when (isSimpleSed s) $
style id 2001 "See if you can use ${variable//search/replace} instead." style id 2001 "See if you can use ${variable//search/replace} instead."