7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added check for echo $foo | wc -c

This commit is contained in:
Vidar Holen 2012-11-25 00:07:53 -08:00
parent aaf5ac6f8f
commit d58bd400ea
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ShellCheck/Analytics.hs
View File

@ -61,7 +61,7 @@ basicChecks = [
,checkPrintfVar ,checkPrintfVar
,checkCommarrays ,checkCommarrays
,checkOrNeq ,checkOrNeq
,checkEchoSed ,checkEcho
] ]
modifyMap = modify modifyMap = modify
@ -111,13 +111,16 @@ checkFull f s = case parseShell "-" s of
_ -> Nothing _ -> Nothing
prop_checkEchoSed1 = verify checkEchoSed "FOO=$(echo \"$cow\" | sed 's/foo/bar/g')" prop_checkEcho1 = verify checkEcho "FOO=$(echo \"$cow\" | sed 's/foo/bar/g')"
prop_checkEchoSed2 = verify checkEchoSed "rm $(echo $cow | sed -e 's,foo,bar,')" prop_checkEcho2 = verify checkEcho "rm $(echo $cow | sed -e 's,foo,bar,')"
checkEchoSed (T_Pipeline id [a, b]) = prop_checkEcho3 = verify checkEcho "n=$(echo $foo | wc -c)"
checkEcho (T_Pipeline id [a, b]) =
when (acmd == ["echo", "${VAR}"]) $ when (acmd == ["echo", "${VAR}"]) $
case bcmd of case bcmd of
["sed", v] -> checkIn v ["sed", v] -> checkIn v
["sed", "-e", v] -> checkIn v ["sed", "-e", v] -> checkIn v
["wc", "-c"] -> countMsg
["wc", "-m"] -> countMsg
_ -> return () _ -> return ()
where where
acmd = deadSimple a acmd = deadSimple a
@ -126,7 +129,8 @@ checkEchoSed (T_Pipeline id [a, b]) =
case matchRegex checkEchoSedRe s of case matchRegex checkEchoSedRe s of
Just _ -> style id $ "See if you can use ${variable//search/replace} instead." Just _ -> style id $ "See if you can use ${variable//search/replace} instead."
_ -> return () _ -> return ()
checkEchoSed _ = return () countMsg = style id $ "See if you can use ${#variable} instead."
checkEcho _ = return ()
checkEchoSedRe = mkRegex "^s(.)(.*)\\1(.*)\\1g?$" checkEchoSedRe = mkRegex "^s(.)(.*)\\1(.*)\\1g?$"
prop_checkUuoc = verify checkUuoc "cat foo | grep bar" prop_checkUuoc = verify checkUuoc "cat foo | grep bar"