7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-08-08 15:27:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1826 from josephcsible/nofromjust

Browse Source 
Use the Identity monad to avoid unnecessary uses of fromJust
This commit is contained in:
Vidar Holen
2020-02-10 18:05:36 -08:00
committed by GitHub
parent b88b253cad 4d92a2e15c
commit d0beac6d0b
5 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ShellCheck/AnalyzerLib.hs
View File

@@ -801,7 +801,7 @@ isVariableName (x:r) = isVariableStartChar x && all isVariableChar r
isVariableName _ = False
getVariablesFromLiteralToken token =
getVariablesFromLiteral (fromJust $ getLiteralStringExt (const $ return " ") token)
getVariablesFromLiteral (getLiteralStringDef " " token)
-- Try to get referenced variables from a literal string like "$foo"
-- Ignores tons of cases like arithmetic evaluation and array indices.