7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add deprecation warning for tempfile

This commit is contained in:
Vidar Holen 2016-12-10 09:58:27 -08:00
parent a40efffec9
commit cf1c46d852
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ShellCheck/Checks/Commands.hs
View File

@ -82,6 +82,7 @@ commandChecks = [
,checkTimeParameters ,checkTimeParameters
,checkTimedCommand ,checkTimedCommand
,checkLocalScope ,checkLocalScope
,checkDeprecatedTempfile
] ]
buildCommandMap :: [CommandCheck] -> Map.Map CommandName (Token -> Analysis) buildCommandMap :: [CommandCheck] -> Map.Map CommandName (Token -> Analysis)
@ -659,5 +660,10 @@ checkLocalScope = CommandCheck (Exactly "local") $ \t ->
unless (any isFunction path) $ unless (any isFunction path) $
err (getId t) 2168 "'local' is only valid in functions." err (getId t) 2168 "'local' is only valid in functions."
prop_checkDeprecatedTempfile1 = verify checkDeprecatedTempfile "var=$(tempfile)"
prop_checkDeprecatedTempfile2 = verifyNot checkDeprecatedTempfile "tempfile=$(mktemp)"
checkDeprecatedTempfile = CommandCheck (Basename "tempfile") $
\t -> warn (getId t) 2186 "tempfile is deprecated. Use mktemp instead."
return [] return []
runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |]) runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |])