7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warn about UTF-8 BOMs in scripts.

This commit is contained in:
Vidar Holen 2014-05-03 10:37:12 -07:00
parent 47c220d59c
commit c566efd442
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ShellCheck/Parser.hs
View File

@ -1271,8 +1271,8 @@ readHereString = called "here string" $ do
readNewlineList = many1 ((newline <|> carriageReturn) `thenSkip` spacing) readNewlineList = many1 ((newline <|> carriageReturn) `thenSkip` spacing)
readLineBreak = optional readNewlineList readLineBreak = optional readNewlineList
prop_roflol = isWarning readScript "a &; b" prop_readSeparator1 = isWarning readScript "a &; b"
prop_roflol2 = isOk readScript "a & b" prop_readSeparator2 = isOk readScript "a & b"
readSeparatorOp = do readSeparatorOp = do
notFollowedBy2 (g_AND_IF <|> g_DSEMI) notFollowedBy2 (g_AND_IF <|> g_DSEMI)
notFollowedBy2 (string "&>") notFollowedBy2 (string "&>")
@ -1917,6 +1917,10 @@ prop_readScript4 = isWarning readScript "#!/usr/bin/perl\nfoo=("
readScript = do readScript = do
id <- getNextId id <- getNextId
pos <- getPosition pos <- getPosition
optional $ do
readUtf8Bom
parseProblem ErrorC 1082 $
"This file has a UTF-8 BOM. Remove it with: LC_CTYPE=C sed '1s/^...//' < yourscript ."
sb <- option "" readShebang sb <- option "" readShebang
verifyShell pos (getShell sb) verifyShell pos (getShell sb)
if (isValidShell $ getShell sb) /= Just False if (isValidShell $ getShell sb) /= Just False
@ -1976,6 +1980,8 @@ readScript = do
"tcsh" "tcsh"
] ]
readUtf8Bom = called "Byte Order Mark" $ string "\xFEFF"
rp p filename contents = Ms.runState (runParserT p initialState filename contents) ([], []) rp p filename contents = Ms.runState (runParserT p initialState filename contents) ([], [])
isWarning p s = (fst cs) && (not . null . snd $ cs) where cs = checkString p s isWarning p s = (fst cs) && (not . null . snd $ cs) where cs = checkString p s