7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Suggest (( expr )) over let expr (#813)

This commit is contained in:
Vidar Holen 2017-09-09 16:07:38 -07:00
parent 895ba31337
commit bd2facb245
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ShellCheck/Checks/Commands.hs
View File

@ -87,6 +87,7 @@ commandChecks = [
,checkDeprecatedFgrep ,checkDeprecatedFgrep
,checkWhileGetoptsCase ,checkWhileGetoptsCase
,checkCatastrophicRm ,checkCatastrophicRm
,checkLetUsage
] ]
buildCommandMap :: [CommandCheck] -> Map.Map CommandName (Token -> Analysis) buildCommandMap :: [CommandCheck] -> Map.Map CommandName (Token -> Analysis)
@ -824,5 +825,13 @@ checkCatastrophicRm = CommandCheck (Basename "rm") $ \t ->
importantPaths = filter (not . null) $ importantPaths = filter (not . null) $
["", "/", "/*", "/*/*"] >>= (\x -> map (++x) paths) ["", "/", "/*", "/*/*"] >>= (\x -> map (++x) paths)
prop_checkLetUsage1 = verify checkLetUsage "let a=1"
prop_checkLetUsage2 = verifyNot checkLetUsage "(( a=1 ))"
checkLetUsage = CommandCheck (Exactly "let") f
where
f t = whenShell [Bash,Ksh] $ do
style (getId t) 2219 $ "Instead of 'let expr', prefer (( expr )) ."
return [] return []
runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |]) runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |])