7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Let checkGrepRe only parse flags once

This commit is contained in:
Vidar Holen 2019-01-08 19:06:00 -08:00
parent 26c55750cf
commit baa4d2e555
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ShellCheck/Checks/Commands.hs
View File

@ -234,7 +234,7 @@ checkGrepRe = CommandCheck (Basename "grep") check where
when (isGlob re) $ when (isGlob re) $
warn (getId re) 2062 "Quote the grep pattern so the shell won't interpret it." warn (getId re) 2062 "Quote the grep pattern so the shell won't interpret it."
unless (any (hasFlag cmd) grepGlobFlags) $ do unless (any (`elem` flags) grepGlobFlags) $ do
let string = concat $ oversimplify re let string = concat $ oversimplify re
if isConfusedGlobRegex string then if isConfusedGlobRegex string then
warn (getId re) 2063 "Grep uses regex, but this looks like a glob." warn (getId re) 2063 "Grep uses regex, but this looks like a glob."
@ -243,6 +243,7 @@ checkGrepRe = CommandCheck (Basename "grep") check where
return $ info (getId re) 2022 $ return $ info (getId re) 2022 $
"Note that unlike globs, " ++ [char] ++ "* here matches '" ++ [char, char, char] ++ "' but not '" ++ wordStartingWith char ++ "'." "Note that unlike globs, " ++ [char] ++ "* here matches '" ++ [char, char, char] ++ "' but not '" ++ wordStartingWith char ++ "'."
where where
flags = map snd $ getAllFlags cmd
grepGlobFlags = ["F", "include", "exclude", "exclude-dir"] grepGlobFlags = ["F", "include", "exclude", "exclude-dir"]
wordStartingWith c = wordStartingWith c =