From af1517146ebdedb51c88b8d6c41d7e7bb4fb9add Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Mon, 5 Nov 2012 01:09:43 -0800 Subject: [PATCH] Upgraded for f in $(ls ..) to Error. I mean, come on. --- Shpell/Analytics.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Shpell/Analytics.hs b/Shpell/Analytics.hs index d7b791d..dac65f1 100644 --- a/Shpell/Analytics.hs +++ b/Shpell/Analytics.hs @@ -89,7 +89,7 @@ checkForInQuoted _ = return () prop_checkForInLs = verify checkForInLs "for f in $(ls *.mp3); do mplayer \"$f\"; done" checkForInLs (T_ForIn _ f [T_NormalWord _ [T_DollarExpansion id [x]]] _) = case deadSimple x of ("ls":n) -> let args = (if n == [] then ["*"] else n) in - addNoteFor id $ Note WarningC $ "Don't use 'for "++f++" in $(ls " ++ (intercalate " " n) ++ ")'. Use 'for "++f++" in "++ (intercalate " " args) ++ "'" + addNoteFor id $ Note ErrorC $ "Don't use 'for "++f++" in $(ls " ++ (intercalate " " n) ++ ")'. Use 'for "++f++" in "++ (intercalate " " args) ++ "'" _ -> return () checkForInLs _ = return ()