7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warn when using deprecated rgrep.

This commit is contained in:
Ben Blank 2023-01-08 13:25:51 -08:00
parent a526ee0829
commit ab9dfe4ee3
No known key found for this signature in database
GPG Key ID: 4FDD76C901E801B2
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ShellCheck/Analytics.hs
View File

@ -3029,7 +3029,7 @@ checkShouldUseGrepQ params t =
T_DollarExpansion _ [x] -> getPipeline x T_DollarExpansion _ [x] -> getPipeline x
T_Pipeline _ _ cmds -> return cmds T_Pipeline _ _ cmds -> return cmds
_ -> fail "unknown" _ -> fail "unknown"
isGrep = (`elem` ["grep", "egrep", "fgrep", "zgrep"]) isGrep = (`elem` ["grep", "egrep", "fgrep", "rgrep", "zgrep"])
prop_checkTestArgumentSplitting1 = verify checkTestArgumentSplitting "[ -e *.mp3 ]" prop_checkTestArgumentSplitting1 = verify checkTestArgumentSplitting "[ -e *.mp3 ]"
prop_checkTestArgumentSplitting2 = verifyNot checkTestArgumentSplitting "[[ $a == *b* ]]" prop_checkTestArgumentSplitting2 = verifyNot checkTestArgumentSplitting "[[ $a == *b* ]]"

5
src/ShellCheck/Checks/Commands.hs
View File

@ -91,6 +91,7 @@ commandChecks = [
,checkDeprecatedTempfile ,checkDeprecatedTempfile
,checkDeprecatedEgrep ,checkDeprecatedEgrep
,checkDeprecatedFgrep ,checkDeprecatedFgrep
,checkDeprecatedRgrep
,checkWhileGetoptsCase ,checkWhileGetoptsCase
,checkCatastrophicRm ,checkCatastrophicRm
,checkLetUsage ,checkLetUsage
@ -988,6 +989,10 @@ prop_checkDeprecatedFgrep = verify checkDeprecatedFgrep "fgrep '*' files"
checkDeprecatedFgrep = CommandCheck (Basename "fgrep") $ checkDeprecatedFgrep = CommandCheck (Basename "fgrep") $
\t -> info (getId $ getCommandTokenOrThis t) 2197 "fgrep is non-standard and deprecated. Use grep -F instead." \t -> info (getId $ getCommandTokenOrThis t) 2197 "fgrep is non-standard and deprecated. Use grep -F instead."
prop_checkDeprecatedRgrep = verify checkDeprecatedRgrep "rgrep '*' dir"
checkDeprecatedRgrep = CommandCheck (Basename "rgrep") $
\t -> info (getId $ getCommandTokenOrThis t) 2324 "rgrep is non-standard and deprecated. Use grep -r instead."
prop_checkWhileGetoptsCase1 = verify checkWhileGetoptsCase "while getopts 'a:b' x; do case $x in a) foo;; esac; done" prop_checkWhileGetoptsCase1 = verify checkWhileGetoptsCase "while getopts 'a:b' x; do case $x in a) foo;; esac; done"
prop_checkWhileGetoptsCase2 = verify checkWhileGetoptsCase "while getopts 'a:' x; do case $x in a) foo;; b) bar;; esac; done" prop_checkWhileGetoptsCase2 = verify checkWhileGetoptsCase "while getopts 'a:' x; do case $x in a) foo;; b) bar;; esac; done"
prop_checkWhileGetoptsCase3 = verifyNot checkWhileGetoptsCase "while getopts 'a:b' x; do case $x in a) foo;; b) bar;; *) :;esac; done" prop_checkWhileGetoptsCase3 = verifyNot checkWhileGetoptsCase "while getopts 'a:b' x; do case $x in a) foo;; b) bar;; *) :;esac; done"