From a6efd02807ad7ae6c8047d4f42fb46150c8bd018 Mon Sep 17 00:00:00 2001 From: "Joseph C. Sible" Date: Sun, 9 Feb 2020 20:45:05 -0500 Subject: [PATCH] Simplify <> for SpaceStatus --- src/ShellCheck/Analytics.hs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/ShellCheck/Analytics.hs b/src/ShellCheck/Analytics.hs index 854dac7..9581b7c 100644 --- a/src/ShellCheck/Analytics.hs +++ b/src/ShellCheck/Analytics.hs @@ -1804,13 +1804,11 @@ prop_checkSpacefulness40= verifyNotTree checkSpacefulness "a=$((x+1)); echo $a" data SpaceStatus = SpaceSome | SpaceNone | SpaceEmpty deriving (Eq) instance Semigroup SpaceStatus where - (<>) x y = - case (x,y) of - (SpaceNone, SpaceNone) -> SpaceNone - (SpaceSome, _) -> SpaceSome - (_, SpaceSome) -> SpaceSome - (SpaceEmpty, x) -> x - (x, SpaceEmpty) -> x + SpaceNone <> SpaceNone = SpaceNone + SpaceSome <> _ = SpaceSome + _ <> SpaceSome = SpaceSome + SpaceEmpty <> x = x + x <> SpaceEmpty = x instance Monoid SpaceStatus where mempty = SpaceEmpty mappend = (<>)