7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check for attempted expansion in single quoted variables

This commit is contained in:
Vidar Holen 2012-11-05 20:03:14 -08:00
parent 0c0b386cf3
commit a25cc75afa
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Shpell/Analytics.hs
View File

@ -7,6 +7,7 @@ import qualified Data.Map as Map
import Data.Char import Data.Char
import Data.List import Data.List
import Debug.Trace import Debug.Trace
import Text.Regex
checks = concat [ checks = concat [
map runBasicAnalysis basicChecks map runBasicAnalysis basicChecks
@ -29,6 +30,7 @@ basicChecks = [
,checkUnquotedDollarAt ,checkUnquotedDollarAt
,checkStderrRedirect ,checkStderrRedirect
,checkMissingPositionalQuotes ,checkMissingPositionalQuotes
,checkSingleQuotedVariables
] ]
modifyMap = modify modifyMap = modify
@ -184,6 +186,18 @@ checkStderrRedirect _ = return ()
lt x = trace ("FAILURE " ++ (show x)) x lt x = trace ("FAILURE " ++ (show x)) x
prop_checkSingleQuotedVariables = verify checkSingleQuotedVariables "echo '$foo'"
prop_checkSingleQuotedVariables2 = verify checkSingleQuotedVariables "echo 'lol$1.jpg'"
prop_checkSingleQuotedVariables3 = verifyNot checkSingleQuotedVariables "sed 's/foo$/bar/'"
checkSingleQuotedVariables (T_SingleQuoted id s) =
case matchRegex checkSingleQuotedVariablesRe s of
Just [var] -> addNoteFor id $ Note WarningC $ var ++ " won't be expanded in single quotes."
_ -> return ()
checkSingleQuotedVariables _ = return ()
checkSingleQuotedVariablesRe = mkRegex "(\\$[0-9a-zA-Z_]+)"
allModifiedVariables t = snd $ runState (doAnalysis (\x -> modify $ (++) (getModifiedVariables t)) t) []
--- Subshell detection --- Subshell detection