7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-09-20 02:33:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix SC1087 to trigger on any $var[, not just $var[@]

Browse Source
This commit is contained in:
Vidar Holen
2018-02-25 18:25:47 -08:00
parent ecb9d07f52
commit 9fc3ddf849
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ShellCheck/Parser.hs
View File

@@ -1541,6 +1541,7 @@ prop_readDollarVariable = isOk readDollarVariable "$@"
prop_readDollarVariable2 = isOk (readDollarVariable >> anyChar) "$?!" prop_readDollarVariable2 = isOk (readDollarVariable >> anyChar) "$?!"
prop_readDollarVariable3 = isWarning (readDollarVariable >> anyChar) "$10" prop_readDollarVariable3 = isWarning (readDollarVariable >> anyChar) "$10"
prop_readDollarVariable4 = isWarning (readDollarVariable >> string "[@]") "$arr[@]" prop_readDollarVariable4 = isWarning (readDollarVariable >> string "[@]") "$arr[@]"
prop_readDollarVariable5 = isWarning (readDollarVariable >> string "[f") "$arr[f"
readDollarVariable = do readDollarVariable = do
id <- getNextId id <- getNextId
@@ -1563,8 +1564,8 @@ readDollarVariable = do
name <- readVariableName name <- readVariableName
value <- wrap name value <- wrap name
return (T_DollarBraced id value) `attempting` do return (T_DollarBraced id value) `attempting` do
lookAhead $ void (string "[@]") <|> void (string "[*]") <|> void readArrayIndex lookAhead $ char '['
parseNoteAt pos ErrorC 1087 "Braces are required when expanding arrays, as in ${array[idx]}." parseNoteAt pos ErrorC 1087 "Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet)."
try $ char '$' >> (positional <|> special <|> regular) try $ char '$' >> (positional <|> special <|> regular)