diff --git a/src/ShellCheck/Analytics.hs b/src/ShellCheck/Analytics.hs index b53aee1..b943cbc 100644 --- a/src/ShellCheck/Analytics.hs +++ b/src/ShellCheck/Analytics.hs @@ -4155,11 +4155,11 @@ checkEqualsInCommand params originalToken = _ | "===" `isPrefixOf` s -> borderMsg (getId originalToken) _ -> prefixMsg (getId cmd) - -- $var==42 + -- '$var==42' _ | "==" `isInfixOf` s -> badComparisonMsg (getId cmd) - -- ${foo[x]}=42 and $foo=42 + -- '${foo[x]}=42' and '$foo=42' [T_DollarBraced id braced l] | "=" `isPrefixOf` s -> do let variableStr = concat $ oversimplify l let variableReference = getBracedReference variableStr @@ -4172,22 +4172,22 @@ checkEqualsInCommand params originalToken = && "]" `isSuffixOf` variableModifier case () of - -- $foo=bar should already have caused a parse-time SC1066 + -- '$foo=bar' should already have caused a parse-time SC1066 -- _ | not braced && isPlain -> -- return () _ | variableStr == "" -> -- Don't try to fix ${}=foo genericMsg (getId cmd) - -- $#=42 or ${#var}=42 + -- '$#=42' or '${#var}=42' _ | "#" `isPrefixOf` variableStr -> genericMsg (getId cmd) - -- ${0}=42 + -- '${0}=42' _ | variableStr == "0" -> assign0Msg id $ fixWith [replaceToken id params "BASH_ARGV0"] - -- $2=2 + -- '$2=2' _ | isPositional -> positionalMsg id diff --git a/test/buildtest b/test/buildtest index 68bd048..1d194fc 100755 --- a/test/buildtest +++ b/test/buildtest @@ -29,6 +29,8 @@ cabal build || die "build failed" cabal test || die "test failed" +cabal haddock || + die "haddock failed" sc="$(find . -name shellcheck -type f -perm -111)" [ -x "$sc" ] || die "Can't find executable"