From 99be2736a1e6b72558cd783059fa808a98de32e6 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Tue, 2 Jul 2013 20:29:07 -0700 Subject: [PATCH] Doubled speed by applying all checks in one iteration. --- ShellCheck/Analytics.hs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index b1e41d0..8bd5cb6 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -31,12 +31,13 @@ import Data.Maybe data Shell = Ksh | Zsh | Sh | Bash deriving (Show, Eq) -genericChecks = concat [ - map runBasicAnalysis basicChecks - ,[runBasicTreeAnalysis treeChecks] - ,[subshellAssignmentCheck] - ,[checkSpacefulness, checkQuotesInLiterals] - ,[checkShebang] +genericChecks = [ + runBasicAnalysis (\x -> mapM_ (flip ($) x) basicChecks) + ,runBasicTreeAnalysis treeChecks + ,subshellAssignmentCheck + ,checkSpacefulness + ,checkQuotesInLiterals + ,checkShebang ] checksFor Sh = map runBasicAnalysis [