7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed x[0] not recognized as reference of x in arithmetics

This commit is contained in:
Vidar Holen 2014-03-01 10:14:17 -08:00
parent 1b806f6c9f
commit 97045c4af1
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ShellCheck/Analytics.hs
View File

@ -1953,22 +1953,24 @@ prop_checkUnused9 = verifyNotTree checkUnusedAssignments "read ''"
prop_checkUnused10= verifyNotTree checkUnusedAssignments "read -p 'test: '" prop_checkUnused10= verifyNotTree checkUnusedAssignments "read -p 'test: '"
prop_checkUnused11= verifyNotTree checkUnusedAssignments "bar=5; export foo[$bar]=3" prop_checkUnused11= verifyNotTree checkUnusedAssignments "bar=5; export foo[$bar]=3"
prop_checkUnused12= verifyNotTree checkUnusedAssignments "read foo; echo ${!foo}" prop_checkUnused12= verifyNotTree checkUnusedAssignments "read foo; echo ${!foo}"
prop_checkUnused13= verifyNotTree checkUnusedAssignments "x=(1); echo ${x[0]}"
checkUnusedAssignments params t = snd $ runWriter (mapM_ checkAssignment flow) checkUnusedAssignments params t = snd $ runWriter (mapM_ checkAssignment flow)
where where
flow = variableFlow params flow = variableFlow params
references = foldl (flip ($)) defaultMap (map insertRef flow) references = foldl (flip ($)) defaultMap (map insertRef flow)
insertRef (Reference (base, token, name)) = insertRef (Reference (base, token, name)) =
Map.insert name () Map.insert (stripSuffix name) ()
insertRef _ = id insertRef _ = id
checkAssignment (Assignment (_, token, name, _)) | isVariableName name = checkAssignment (Assignment (_, token, name, _)) | isVariableName name =
case Map.lookup name references of case Map.lookup name references of
Just _ -> return () Just _ -> return ()
Nothing -> do Nothing ->
info (getId token) 2034 $ info (getId token) 2034 $
name ++ " appears unused. Verify it or export it." name ++ " appears unused. Verify it or export it."
checkAssignment _ = return () checkAssignment _ = return ()
stripSuffix str = takeWhile isVariableChar str
defaultMap = Map.fromList $ zip internalVariables $ repeat () defaultMap = Map.fromList $ zip internalVariables $ repeat ()
prop_checkGlobsAsOptions1 = verify checkGlobsAsOptions "rm *.txt" prop_checkGlobsAsOptions1 = verify checkGlobsAsOptions "rm *.txt"