From 90c1b6379035c934c5083d2e1e8748930130e075 Mon Sep 17 00:00:00 2001
From: Vidar Holen <spam@vidarholen.net>
Date: Mon, 5 Nov 2012 18:33:45 -0800
Subject: [PATCH] Added read/export as variable modifying commands for
 subshells

---
 Shpell/Analytics.hs  | 36 ++++++++++++++++++++++++++++++------
 badcase/subshellvar  |  4 ++--
 badcase/subshellvar3 |  3 +++
 3 files changed, 35 insertions(+), 8 deletions(-)
 create mode 100644 badcase/subshellvar3

diff --git a/Shpell/Analytics.hs b/Shpell/Analytics.hs
index eeb7a4f..577937a 100644
--- a/Shpell/Analytics.hs
+++ b/Shpell/Analytics.hs
@@ -65,9 +65,12 @@ deadSimple _ = []
 
 verify f s = checkBasic f s == Just True
 verifyNot f s = checkBasic f s == Just False
+verifyFull f s = checkFull f s == Just True
+verifyNotFull f s = checkFull f s == Just False
 
-checkBasic f s = case parseShell "-" s of
-        (ParseResult (Just (t, m)) _) -> Just . not $ (notesFromMap $ runBasicAnalysis f t m) == (notesFromMap m)
+checkBasic f s = checkFull (runBasicAnalysis f) s
+checkFull f s = case parseShell "-" s of
+        (ParseResult (Just (t, m)) _) -> Just . not $ (notesFromMap $ f t m) == (notesFromMap m)
         _ -> Nothing
 
 
@@ -171,12 +174,18 @@ checkStderrRedirect (T_Redirecting _ [
          where error = addNoteFor id $ Note ErrorC $ "The order of the 2>&1 and the redirect matters. The 2>&1 has to be last."
 checkStderrRedirect _ = return ()
 
-lt x = trace (show x) x
+lt x = trace ("FAILURE " ++ (show x)) x
 
 
 
 --- Subshell detection
 
+prop_subshellAssignmentCheck = verifyFull     subshellAssignmentCheck "cat foo | while read bar; do a=$bar; done; echo \"$a\""
+prop_subshellAssignmentCheck2 = verifyNotFull subshellAssignmentCheck "while read bar; do a=$bar; done < file; echo \"$a\""
+prop_subshellAssignmentCheck3 = verifyFull    subshellAssignmentCheck "( A=foo; ); rm $A"
+prop_subshellAssignmentCheck4 = verifyNotFull subshellAssignmentCheck "( A=foo; rm $A; )"
+prop_subshellAssignmentCheck5 = verifyFull    subshellAssignmentCheck "cat foo | while read cow; do true; done; echo $cow;"
+prop_subshellAssignmentCheck6 = verifyFull    subshellAssignmentCheck "( export lol=$(ls); ); echo $lol;"
 subshellAssignmentCheck t map =
     let flow = getVariableFlow t
         check = findSubshelled flow [[]] Map.empty 
@@ -204,14 +213,29 @@ getModifiedVariables t =
                                 T_Assignment id name _ -> [(id, name)]
                                 _ -> []
                       ) vars
-        T_SimpleCommand _ vars commandLine@(_:_) -> 
-            getModifiedVariableCommand commandLine
+        c@(T_SimpleCommand _ _ _) -> 
+            getModifiedVariableCommand c
 
         --Points to 'for' rather than variable
         T_ForIn id str _ _ -> [(id, str)] 
         _ -> []
 
-getModifiedVariableCommand list = [] -- TODO
+getModifiedVariableCommand (T_SimpleCommand _ _ ((T_NormalWord _ ((T_Literal _ x):_)):rest)) = 
+    case x of 
+        "read" -> concatMap getLiteral rest
+        "export" -> concatMap exportParamToLiteral rest
+        _ -> []
+getModifiedVariableCommand _ = [] 
+
+getLiteral (T_NormalWord _ [T_Literal id s]) = [(id,s)]
+getLiteral (T_NormalWord _ [T_DoubleQuoted _ [T_Literal id s]]) = [(id,s)]
+getLiteral x = []
+
+exportParamToLiteral (T_NormalWord _ ((T_Literal id s):_)) =
+    [(id,prefix)] 
+    where prefix = takeWhile (/= '=') s
+exportParamToLiteral _ = []
+
 getBracedReference s = s -- TODO
 
 getReferencedVariables t =
diff --git a/badcase/subshellvar b/badcase/subshellvar
index e5b2267..986127b 100644
--- a/badcase/subshellvar
+++ b/badcase/subshellvar
@@ -1,2 +1,2 @@
-echo cow | while read foo; do DIR=$foo; done
-echo $DIR
+echo cow | read foo
+echo "$foo"
diff --git a/badcase/subshellvar3 b/badcase/subshellvar3
new file mode 100644
index 0000000..fcc3553
--- /dev/null
+++ b/badcase/subshellvar3
@@ -0,0 +1,3 @@
+export lol=32 &
+wait
+echo "$lol"