7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix SC2143 to not warn about pgrep and other quasi-greps.

This commit is contained in:
Vidar Holen 2015-03-12 08:31:49 -07:00
parent 0a80188363
commit 8e554ae3d4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ShellCheck/Analytics.hs
View File

@ -3188,6 +3188,7 @@ prop_checkGrepQ2= verify checkShouldUseGrepQ "[ -z $(fgrep lol) ]"
prop_checkGrepQ3= verify checkShouldUseGrepQ "[ -n \"$(foo | zgrep lol)\" ]" prop_checkGrepQ3= verify checkShouldUseGrepQ "[ -n \"$(foo | zgrep lol)\" ]"
prop_checkGrepQ4= verifyNot checkShouldUseGrepQ "[ -z $(grep bar | cmd) ]" prop_checkGrepQ4= verifyNot checkShouldUseGrepQ "[ -z $(grep bar | cmd) ]"
prop_checkGrepQ5= verifyNot checkShouldUseGrepQ "rm $(ls | grep file)" prop_checkGrepQ5= verifyNot checkShouldUseGrepQ "rm $(ls | grep file)"
prop_checkGrepQ6= verifyNot checkShouldUseGrepQ "[[ -n $(pgrep foo) ]]"
checkShouldUseGrepQ params t = checkShouldUseGrepQ params t =
potentially $ case t of potentially $ case t of
TC_Noary id _ token -> check id True token TC_Noary id _ token -> check id True token
@ -3216,7 +3217,7 @@ checkShouldUseGrepQ params t =
T_DollarExpansion _ [x] -> getPipeline x T_DollarExpansion _ [x] -> getPipeline x
T_Pipeline _ _ cmds -> return cmds T_Pipeline _ _ cmds -> return cmds
_ -> fail "unknown" _ -> fail "unknown"
isGrep = isSuffixOf "grep" isGrep = (`elem` ["grep", "egrep", "fgrep", "zgrep"])
prop_checkTestGlobs1 = verify checkTestGlobs "[ -e *.mp3 ]" prop_checkTestGlobs1 = verify checkTestGlobs "[ -e *.mp3 ]"
prop_checkTestGlobs2 = verifyNot checkTestGlobs "[[ $a == *b* ]]" prop_checkTestGlobs2 = verifyNot checkTestGlobs "[[ $a == *b* ]]"