7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added check for while $((n>3)); do ..

This commit is contained in:
Vidar Holen 2012-11-27 23:38:44 -08:00
parent 396541f3c2
commit 8db22b02e1
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ShellCheck/Analytics.hs
View File

@ -69,6 +69,7 @@ basicChecks = [
,checkUuoe ,checkUuoe
,checkFindNameGlob ,checkFindNameGlob
,checkGrepRe ,checkGrepRe
,checkDollarArithmeticCommand
] ]
modifyMap = modify modifyMap = modify
@ -412,6 +413,15 @@ checkOrNeq (TA_Binary id "||" (TA_Binary _ "!=" word1 _) (TA_Binary _ "!=" word2
warn id "You probably wanted && here." warn id "You probably wanted && here."
checkOrNeq _ = return () checkOrNeq _ = return ()
prop_checkDollarArithmeticCommand1 = verify checkDollarArithmeticCommand "while $((n>10)); do echo foo; done"
prop_checkDollarArithmeticCommand2 = verify checkDollarArithmeticCommand "$(( n++ ))"
prop_checkDollarArithmeticCommand3 = verifyNot checkDollarArithmeticCommand "if (( n > 10 )); then echo foo; fi"
prop_checkDollarArithmeticCommand4 = verifyNot checkDollarArithmeticCommand "echo $((n+3))"
checkDollarArithmeticCommand (T_SimpleCommand _ [] [T_NormalWord _ [T_DollarArithmetic id _]]) =
err id "Use ((..)) instead of $((..)) when running as a command."
checkDollarArithmeticCommand _ = return ()
allModifiedVariables t = snd $ runState (doAnalysis (\x -> modify $ (++) (getModifiedVariables x)) t) [] allModifiedVariables t = snd $ runState (doAnalysis (\x -> modify $ (++) (getModifiedVariables x)) t) []
--- Context seeking --- Context seeking