7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-08-08 14:27:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Warn about spaces around = in alias (fixes #2442)

Browse Source
This commit is contained in:
Vidar Holen
2022-02-03 19:23:46 -08:00
parent 2292e852e5
commit 88cdb4e2c9
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ShellCheck/Checks/Commands.hs
View File

@@ -98,7 +98,7 @@ commandChecks = [
,checkUnquotedEchoSpaces ,checkUnquotedEchoSpaces
,checkEvalArray ,checkEvalArray
] ]
++ map checkArgComparison declaringCommands ++ map checkArgComparison ("alias" : declaringCommands)
++ map checkMaskedReturns declaringCommands ++ map checkMaskedReturns declaringCommands
@@ -1253,6 +1253,7 @@ prop_checkArgComparison3 = verifyNot (checkArgComparison "declare") "declare a=b
prop_checkArgComparison4 = verify (checkArgComparison "export") "export a +=b" prop_checkArgComparison4 = verify (checkArgComparison "export") "export a +=b"
prop_checkArgComparison7 = verifyNot (checkArgComparison "declare") "declare -a +i foo" prop_checkArgComparison7 = verifyNot (checkArgComparison "declare") "declare -a +i foo"
prop_checkArgComparison8 = verify (checkArgComparison "let") "let x = 0" prop_checkArgComparison8 = verify (checkArgComparison "let") "let x = 0"
prop_checkArgComparison9 = verify (checkArgComparison "alias") "alias x =0"
-- This mirrors checkSecondArgIsComparison but for arguments to local/readonly/declare/export -- This mirrors checkSecondArgIsComparison but for arguments to local/readonly/declare/export
checkArgComparison cmd = CommandCheck (Exactly cmd) wordsWithEqual checkArgComparison cmd = CommandCheck (Exactly cmd) wordsWithEqual
where where