Warn when finding HTML entities like &

2025-08-07 17:14:13 +08:00 · 2017-01-14 11:59:31 -08:00
parent 7f307c5775
commit 8809a36952
1 changed files with 8 additions and 0 deletions
--- a/ShellCheck/Parser.hs
+++ b/ShellCheck/Parser.hs
@@ -1696,11 +1696,19 @@ readLineBreak = optional readNewlineList

 prop_readSeparator1 = isWarning readScript "a &; b"
 prop_readSeparator2 = isOk readScript "a & b"
+prop_readSeparator3 = isWarning readScript "a &amp; b"
+prop_readSeparator4 = isWarning readScript "a &gt; file; b"
 readSeparatorOp = do
    notFollowedBy2 (void g_AND_IF <|> void readCaseSeparator)
    notFollowedBy2 (string "&>")
    f <- try (do
+                    pos <- getPosition
                    char '&'
+                    optional $ do
+                        s <- lookAhead . choice . map (try . string) $
+                            ["amp;", "gt;", "lt;"]
+                        parseProblemAt pos ErrorC 1109 "This is an unquoted HTML entity. Replace with corresponding character."
+
                    spacing
                    pos <- getPosition
                    char ';'