7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Count | as a regex metacharacter for 2076.

This commit is contained in:
Vidar Holen 2017-01-12 19:02:46 -08:00
parent edb01fa855
commit 7f307c5775
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ShellCheck/Analytics.hs
View File

@ -973,6 +973,7 @@ prop_checkQuotedCondRegex2 = verify checkQuotedCondRegex "[[ $foo =~ '(cow|bar)'
prop_checkQuotedCondRegex3 = verifyNot checkQuotedCondRegex "[[ $foo =~ $foo ]]" prop_checkQuotedCondRegex3 = verifyNot checkQuotedCondRegex "[[ $foo =~ $foo ]]"
prop_checkQuotedCondRegex4 = verifyNot checkQuotedCondRegex "[[ $foo =~ \"bar\" ]]" prop_checkQuotedCondRegex4 = verifyNot checkQuotedCondRegex "[[ $foo =~ \"bar\" ]]"
prop_checkQuotedCondRegex5 = verifyNot checkQuotedCondRegex "[[ $foo =~ 'cow bar' ]]" prop_checkQuotedCondRegex5 = verifyNot checkQuotedCondRegex "[[ $foo =~ 'cow bar' ]]"
prop_checkQuotedCondRegex6 = verify checkQuotedCondRegex "[[ $foo =~ 'cow|bar' ]]"
checkQuotedCondRegex _ (TC_Binary _ _ "=~" _ rhs) = checkQuotedCondRegex _ (TC_Binary _ _ "=~" _ rhs) =
case rhs of case rhs of
T_NormalWord id [T_DoubleQuoted _ _] -> error rhs T_NormalWord id [T_DoubleQuoted _ _] -> error rhs
@ -983,7 +984,7 @@ checkQuotedCondRegex _ (TC_Binary _ _ "=~" _ rhs) =
unless (isConstantNonRe t) $ unless (isConstantNonRe t) $
err (getId t) 2076 err (getId t) 2076
"Don't quote rhs of =~, it'll match literally rather than as a regex." "Don't quote rhs of =~, it'll match literally rather than as a regex."
re = mkRegex "[][*.+()]" re = mkRegex "[][*.+()|]"
hasMetachars s = s `matches` re hasMetachars s = s `matches` re
isConstantNonRe t = fromMaybe False $ do isConstantNonRe t = fromMaybe False $ do
s <- getLiteralString t s <- getLiteralString t