7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed misplaced uuoc for 'cat foo' outside pipe.

This commit is contained in:
Vidar Holen 2013-07-04 14:27:03 -07:00
parent 10b5e44ad0
commit 73c6202842
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ShellCheck/Analytics.hs
View File

@ -273,7 +273,8 @@ checkAssignAteCommand _ = return ()
prop_checkUuoc1 = verify checkUuoc "cat foo | grep bar" prop_checkUuoc1 = verify checkUuoc "cat foo | grep bar"
prop_checkUuoc2 = verifyNot checkUuoc "cat * | grep bar" prop_checkUuoc2 = verifyNot checkUuoc "cat * | grep bar"
prop_checkUuoc3 = verify checkUuoc "cat $var | grep bar" prop_checkUuoc3 = verify checkUuoc "cat $var | grep bar"
checkUuoc = checkCommand "cat" f prop_checkUuoc4 = verifyNot checkUuoc "cat $var"
checkUuoc (T_Pipeline _ ((T_Redirecting _ _ cmd):_:_)) = checkCommand "cat" f cmd
where where
f [word] = when (isSimple word) $ f [word] = when (isSimple word) $
style (getId word) "Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead." style (getId word) "Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead."
@ -281,6 +282,7 @@ checkUuoc = checkCommand "cat" f
isSimple (T_NormalWord _ parts) = all isSimple parts isSimple (T_NormalWord _ parts) = all isSimple parts
isSimple (T_DollarBraced _ _) = True isSimple (T_DollarBraced _ _) = True
isSimple x = not $ willSplit x isSimple x = not $ willSplit x
checkUuoc _ = return ()
prop_checkNeedlessCommands = verify checkNeedlessCommands "foo=$(expr 3 + 2)" prop_checkNeedlessCommands = verify checkNeedlessCommands "foo=$(expr 3 + 2)"
checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "expr" = checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "expr" =
@ -1418,8 +1420,8 @@ checkSpacefulness t =
readF _ token name = do readF _ token name = do
spaced <- hasSpaces name spaced <- hasSpaces name
if spaced if spaced
&& (not $ inUnquotableContext parents token) && (not $ inUnquotableContext parents token)
&& (not $ usedAsCommandName parents token) && (not $ usedAsCommandName parents token)
then return [(getId token, Note InfoC warning)] then return [(getId token, Note InfoC warning)]
else return [] else return []