From 73a41cdd2febac98cf0dea35decf1a56b89e22de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Adri=C3=A1n=20Ontivero?= Date: Fri, 28 Dec 2018 00:23:17 -0300 Subject: [PATCH] Check jobs flags in dash/POSIX sh (fixes #1429) --- src/ShellCheck/Checks/ShellSupport.hs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ShellCheck/Checks/ShellSupport.hs b/src/ShellCheck/Checks/ShellSupport.hs index 02f2bfa..204c641 100644 --- a/src/ShellCheck/Checks/ShellSupport.hs +++ b/src/ShellCheck/Checks/ShellSupport.hs @@ -138,6 +138,10 @@ prop_checkBashisms55= verify checkBashisms "#!/bin/sh\necho ${@%foo}" prop_checkBashisms56= verifyNot checkBashisms "#!/bin/sh\necho ${##}" prop_checkBashisms57= verifyNot checkBashisms "#!/bin/dash\nulimit -c 0" prop_checkBashisms58= verify checkBashisms "#!/bin/sh\nulimit -c 0" +prop_checkBashisms59 = verify checkBashisms "#!/bin/sh\njobs -s" +prop_checkBashisms60 = verifyNot checkBashisms "#!/bin/sh\njobs -p" +prop_checkBashisms61 = verifyNot checkBashisms "#!/bin/sh\njobs -lp" + checkBashisms = ForShell [Sh, Dash] $ \t -> do params <- ask kludge params t @@ -283,6 +287,7 @@ checkBashisms = ForShell [Sh, Dash] $ \t -> do allowedFlags = Map.fromList [ ("exec", []), ("export", ["-p"]), + ("jobs", ["l", "p"]), ("printf", []), ("read", if isDash then ["r", "p"] else ["r"]), ("ulimit", if isDash then ["H", "S", "t", "f", "d", "s", "c", "m", "l", "p", "n"] else ["f"])