From 6a4b86cbea0c9d4d864ccd10f8648f0bfb14d6c1 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Sat, 24 Sep 2016 14:08:00 -0700 Subject: [PATCH] Fix warning for >& --- ShellCheck/Analytics.hs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index 9bdc9da..01c0a14 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -502,6 +502,7 @@ prop_checkBashisms47= verify checkBashisms "#!/bin/dash\necho foo 42>/dev/null" prop_checkBashisms48= verifyNot checkBashisms "#!/bin/dash\necho $LINENO" prop_checkBashisms49= verify checkBashisms "#!/bin/dash\necho $MACHTYPE" prop_checkBashisms50= verify checkBashisms "#!/bin/sh\ncmd >& file" +prop_checkBashisms51= verifyNot checkBashisms "#!/bin/sh\ncmd 2>&1" checkBashisms params = bashism where isDash = shellType params == Dash @@ -533,7 +534,7 @@ checkBashisms params = bashism warnMsg id $ filter (/= '|') op ++ " is" bashism (TA_Binary id "**" _ _) = warnMsg id "exponentials are" bashism (T_FdRedirect id "&" (T_IoFile _ (T_Greater _) _)) = warnMsg id "&> is" - bashism (T_FdRedirect id _ (T_IoFile _ (T_GREATAND _) _)) = warnMsg id ">& is" + bashism (T_FdRedirect id "" (T_IoFile _ (T_GREATAND _) _)) = warnMsg id ">& is" bashism (T_FdRedirect id ('{':_) _) = warnMsg id "named file descriptors are" bashism (T_FdRedirect id num _) | all isDigit num && length num > 1 = warnMsg id "FDs outside 0-9 are"