Only read --rcfile once, and skip search if unavailable

shellcheck.hs

@@ -77,7 +77,7 @@ data Options = Options {
     sourcePaths      :: [FilePath],
     formatterOptions :: FormatterOptions,
     minSeverity      :: Severity,
-    rcfile           :: FilePath
+    rcfile           :: Maybe FilePath
 }
 
 defaultOptions = Options {
@@ -88,7 +88,7 @@ defaultOptions = Options {
         foColorOption = ColorAuto
     },
     minSeverity = StyleC,
-    rcfile = []
+    rcfile = Nothing
 }
 
 usageHeader = "Usage: shellcheck [OPTIONS...] FILES..."
@@ -374,7 +374,7 @@ parseOption flag options =
 
         Flag "rcfile" str -> do
             return options {
-                rcfile = str 
+                rcfile = Just str
             }
 
         Flag "enable" value ->
@@ -453,21 +453,31 @@ ioInterface options files = do
 
 
     -- Returns the name and contents of .shellcheckrc for the given file
-    getConfig cache filename = do
+    getConfig cache filename =
-        contents <- readConfig (rcfile options)
+        case rcfile options of
-        if isNothing contents
+            Just file -> do
-          then do
+                -- We have a specified rcfile. Ignore normal rcfile resolution.
-            path <- normalize filename
+                (path, result) <- readIORef cache
-            let dir = takeDirectory path
+                if path == "/"
-            (previousPath, result) <- readIORef cache
+                  then return result
-            if dir == previousPath
+                  else do
-              then return result
+                    result <- readConfig file
-              else do
+                    when (isNothing result) $
-                paths <- getConfigPaths dir
+                        hPutStrLn stderr $ "Warning: unable to read --rcfile " ++ file
-                result <- findConfig paths
+                    writeIORef cache ("/", result)
-                writeIORef cache (dir, result)
+                    return result
-                return result
+
-          else return contents
+            Nothing -> do
+                path <- normalize filename
+                let dir = takeDirectory path
+                (previousPath, result) <- readIORef cache
+                if dir == previousPath
+                  then return result
+                  else do
+                    paths <- getConfigPaths dir
+                    result <- findConfig paths
+                    writeIORef cache (dir, result)
+                    return result
 
     findConfig paths =
         case paths of
@@ -505,7 +515,7 @@ ioInterface options files = do
       where
         handler :: FilePath -> IOException -> IO (String, Bool)
         handler file err = do
-            putStrLn $ file ++ ": " ++ show err
+            hPutStrLn stderr $ file ++ ": " ++ show err
             return ("", True)
 
     andM a b arg = do