7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added warning for a && b || c

This commit is contained in:
Vidar Holen 2012-11-04 22:14:47 -08:00
parent 67d27ea42d
commit 69183f6609
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Shpell/Analytics.hs
View File

@ -19,7 +19,8 @@ basicChecks = [
checkForInLs, checkForInLs,
checkMissingForQuotes, checkMissingForQuotes,
checkUnquotedExpansions, checkUnquotedExpansions,
checkRedirectToSame checkRedirectToSame,
checkShorthandIf
] ]
modifyMap = modify modifyMap = modify
@ -128,4 +129,10 @@ checkRedirectToSame s@(T_Pipeline _ list) =
checkRedirectToSame _ = return () checkRedirectToSame _ = return ()
prop_checkShorthandIf = verify checkShorthandIf "[[ ! -z file ]] && scp file host || rm file"
prop_checkShorthandIf2 = verifyNot checkShorthandIf "[[ ! -z file ]] && { scp file host || echo 'Eek'; }"
checkShorthandIf (T_AndIf id _ (T_OrIf _ _ _)) =
addNoteFor id $ Note InfoC "Note that A && B || C is not if-then-else. C may run when A is true."
checkShorthandIf _ = return ()
lt x = trace (show x) x lt x = trace (show x) x

2
badcase/poormansif Normal file
View File

@ -0,0 +1,2 @@
# When the network goes down, the backup gets deleted
[[ ! -z backup ]] && scp backup host: || rm backup