From 62566ee016fa5c6560fc7ec34d14302e5219451e Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Wed, 24 Jul 2013 00:17:31 -0700 Subject: [PATCH] Clarified warning for expr --- ShellCheck/Analytics.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index cf7cdb3..034ee06 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -297,7 +297,7 @@ checkUuoc _ = return () prop_checkNeedlessCommands = verify checkNeedlessCommands "foo=$(expr 3 + 2)" prop_checkNeedlessCommands2 = verify checkNeedlessCommands "foo=`echo \\`expr 3 + 2\\``" checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "expr" = - style id "Use $((..)), ${} or [[ ]] in place of antiquated expr." + style id "expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]." checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "dirname" = style id "Use parameter expansion instead, such as ${var%/*}." checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "basename" =