7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-08-27 17:38:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'fix-3164' of github.com:e-kwsm/shellcheck into e-kwsm-fix-3164

Browse Source
This commit is contained in:
Vidar Holen
2025-07-28 14:08:25 -07:00
parent bbd5d211cf 34cdbaa5e0
commit 60c0be98b6
2 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/ShellCheck/Analytics.hs
View File

@@ -3996,6 +3996,11 @@ prop_checkInvertedStringTest2 = verify checkInvertedStringTest "! [[ -n $var ]]"
prop_checkInvertedStringTest3 = verifyNot checkInvertedStringTest "! [ -x $var ]"
prop_checkInvertedStringTest4 = verifyNot checkInvertedStringTest "[[ ! -w $var ]]"
prop_checkInvertedStringTest5 = verifyNot checkInvertedStringTest "[ -z $var ]"
prop_checkInvertedStringTest6 = verify checkInvertedStringTest "! [ $var != foo ]"
prop_checkInvertedStringTest7 = verify checkInvertedStringTest "[[ ! $var == foo ]]"
prop_checkInvertedStringTest8 = verifyNot checkInvertedStringTest "! [[ $var =~ .* ]]"
prop_checkInvertedStringTest9 = verify checkInvertedStringTest "[ ! $var -eq 0 ]"
prop_checkInvertedStringTest10 = verify checkInvertedStringTest "! [[ $var -gt 3 ]]"
checkInvertedStringTest _ t =
case t of
TC_Unary _ _ "!" (TC_Unary _ _ op _) ->
@@ -4003,12 +4008,37 @@ checkInvertedStringTest _ t =
"-n" -> style (getId t) 2236 "Use -z instead of ! -n."
"-z" -> style (getId t) 2236 "Use -n instead of ! -z."
_ -> return ()
TC_Unary _ _ "!" (TC_Binary _ _ op _ _) ->
case op of
"=" -> style (getId t) 2335 "Use a != b instead of ! a = b."
"==" -> style (getId t) 2335 "Use a != b instead of ! a == b."
"!=" -> style (getId t) 2335 "Use a = b instead of ! a != b."
"-eq" -> style (getId t) 2335 "Use a -ne b instead of ! a -eq b."
"-ne" -> style (getId t) 2335 "Use a -eq b instead of ! a -ne b."
"-gt" -> style (getId t) 2335 "Use a -le b instead of ! a -gt b."
"-ge" -> style (getId t) 2335 "Use a -lt b instead of ! a -ge b."
"-lt" -> style (getId t) 2335 "Use a -ge b instead of ! a -lt b."
"-le" -> style (getId t) 2335 "Use a -gt b instead of ! a -le b."
_ -> return ()
T_Banged _ (T_Pipeline _ _
[T_Redirecting _ _ (T_Condition _ _ (TC_Unary _ _ op _))]) ->
case op of
"-n" -> style (getId t) 2237 "Use [ -z .. ] instead of ! [ -n .. ]."
"-z" -> style (getId t) 2237 "Use [ -n .. ] instead of ! [ -z .. ]."
_ -> return ()
T_Banged _ (T_Pipeline _ _
[T_Redirecting _ _ (T_Condition _ _ (TC_Binary _ _ op _ _))]) ->
case op of
"=" -> style (getId t) 2335 "Use [ a != b ] instead of ! [ a = b ]."
"==" -> style (getId t) 2335 "Use [[ a != b ]] instead of ! [[ a == b ]]."
"!=" -> style (getId t) 2335 "Use [ a = b ] instead of ! [ a != b ]."
"-eq" -> style (getId t) 2335 "Use [ a -ne b ] instead of ! [ a -eq b ]."
"-ne" -> style (getId t) 2335 "Use [ a -eq b ] instead of ! [ a -ne b ]."
"-gt" -> style (getId t) 2335 "Use [ a -le b ] instead of ! [ a -gt b ]."
"-ge" -> style (getId t) 2335 "Use [ a -lt b ] instead of ! [ a -ge b ]."
"-lt" -> style (getId t) 2335 "Use [ a -ge b ] instead of ! [ a -lt b ]."
"-le" -> style (getId t) 2335 "Use [ a -gt b ] instead of ! [ a -le b ]."
_ -> return ()
_ -> return ()
prop_checkRedirectionToCommand1 = verify checkRedirectionToCommand "ls > rm"