7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow `#inline comments` without SC2046.

This commit is contained in:
Vidar Holen 2016-09-05 12:38:35 -07:00
parent 47a7065a7a
commit 5a46eeb09a
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ShellCheck/Analytics.hs
View File

@ -774,16 +774,17 @@ prop_checkUnquotedExpansions5 = verifyNot checkUnquotedExpansions "for f in $(cm
prop_checkUnquotedExpansions6 = verifyNot checkUnquotedExpansions "$(cmd)" prop_checkUnquotedExpansions6 = verifyNot checkUnquotedExpansions "$(cmd)"
prop_checkUnquotedExpansions7 = verifyNot checkUnquotedExpansions "cat << foo\n$(ls)\nfoo" prop_checkUnquotedExpansions7 = verifyNot checkUnquotedExpansions "cat << foo\n$(ls)\nfoo"
prop_checkUnquotedExpansions8 = verifyNot checkUnquotedExpansions "set -- $(seq 1 4)" prop_checkUnquotedExpansions8 = verifyNot checkUnquotedExpansions "set -- $(seq 1 4)"
prop_checkUnquotedExpansions9 = verifyNot checkUnquotedExpansions "echo foo `# inline comment`"
checkUnquotedExpansions params = checkUnquotedExpansions params =
check check
where where
check t@(T_DollarExpansion _ _) = examine t check t@(T_DollarExpansion _ c) = examine t c
check t@(T_Backticked _ _) = examine t check t@(T_Backticked _ c) = examine t c
check t@(T_DollarBraceCommandExpansion _ _) = examine t check t@(T_DollarBraceCommandExpansion _ c) = examine t c
check _ = return () check _ = return ()
tree = parentMap params tree = parentMap params
examine t = examine t contents =
unless (shouldBeSplit t || isQuoteFree tree t || usedAsCommandName tree t) $ unless (null contents || shouldBeSplit t || isQuoteFree tree t || usedAsCommandName tree t) $
warn (getId t) 2046 "Quote this to prevent word splitting." warn (getId t) 2046 "Quote this to prevent word splitting."
shouldBeSplit t = shouldBeSplit t =