7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-09-22 03:45:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Suggest pgrep when grepping ps

Browse Source
This commit is contained in:
Vidar Holen
2013-08-31 18:32:07 -07:00
parent 9586a46c9c
commit 58b8e0ab70
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ShellCheck/Analytics.hs
View File

@@ -364,6 +364,9 @@ checkPipePitfalls (T_Pipeline id commands) = do
for ["?", "echo"] $ for ["?", "echo"] $
\(_:echo:_) -> info (getId echo) "echo doesn't read from stdin, are you sure you should be piping to it?" \(_:echo:_) -> info (getId echo) "echo doesn't read from stdin, are you sure you should be piping to it?"
for' ["ps", "grep"] $
flip info "Consider using pgrep instead of grepping ps output."
didLs <- liftM or . sequence $ [ didLs <- liftM or . sequence $ [
for' ["ls", "grep"] $ for' ["ls", "grep"] $
flip warn "Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.", flip warn "Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.",