diff --git a/CHANGELOG.md b/CHANGELOG.md index 9eec957..f6d5a82 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ - SC2264: Warn about wrapper functions that blatantly recurse - SC2265/SC2266: Warn when using & or | with test statements - SC2267: Warn when using xargs -i instead of -I -- Optional avoid-x-comparisons: Style warning SC2268 for `[ x$var = xval ]` +- SC2268: Warn about unnecessary x-comparisons like `[ x$var = xval ]` ### Fixed - SC1072/SC1073 now respond to disable annotations, though ignoring parse errors diff --git a/src/ShellCheck/Analytics.hs b/src/ShellCheck/Analytics.hs index 9035e04..b53aee1 100644 --- a/src/ShellCheck/Analytics.hs +++ b/src/ShellCheck/Analytics.hs @@ -196,6 +196,7 @@ nodeChecks = [ ,checkAssignToSelf ,checkEqualsInCommand ,checkSecondArgIsComparison + ,checkComparisonWithLeadingX ] optionalChecks = map fst optionalTreeChecks @@ -243,13 +244,6 @@ optionalTreeChecks = [ cdPositive = "echo $VAR", cdNegative = "VAR=hello; echo $VAR" }, checkUnassignedReferences' True) - - ,(newCheckDescription { - cdName = "avoid-x-comparisons", - cdDescription = "Warn about 'x'-prefix in comparisons", - cdPositive = "[ \"x$var\" = xval ]", - cdNegative = "[ \"$var\" = val ]" - }, nodeChecksToTreeCheck [checkComparisonWithLeadingX]) ] optionalCheckMap :: Map.Map String (Parameters -> Token -> [TokenComment]) @@ -4006,7 +4000,7 @@ checkComparisonWithLeadingX params t = check lhs rhs _ -> return () where - msg = "Avoid outdated x-prefix in comparisons as it no longer serves a purpose." + msg = "Avoid x-prefix in comparisons as it no longer serves a purpose." check lhs rhs = sequence_ $ do l <- fixLeadingX lhs r <- fixLeadingX rhs