7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warn when redirecting to a literal integer.

This commit is contained in:
Vidar Holen 2017-04-15 17:20:33 -07:00
parent 4f9a80db15
commit 4fb1080809
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ShellCheck/Analytics.hs
View File

@ -161,6 +161,7 @@ nodeChecks = [
,checkUnmatchableCases ,checkUnmatchableCases
,checkSubshellAsTest ,checkSubshellAsTest
,checkSplittingInArrays ,checkSplittingInArrays
,checkRedirectionToNumber
] ]
@ -2796,5 +2797,16 @@ checkSplittingInArrays params t =
else "Prefer mapfile or read -a to split command output (or quote to avoid splitting)." else "Prefer mapfile or read -a to split command output (or quote to avoid splitting)."
prop_checkRedirectionToNumber1 = verify checkRedirectionToNumber "( 1 > 2 )"
prop_checkRedirectionToNumber2 = verify checkRedirectionToNumber "foo 1>2"
prop_checkRedirectionToNumber3 = verifyNot checkRedirectionToNumber "echo foo > '2'"
prop_checkRedirectionToNumber4 = verifyNot checkRedirectionToNumber "foo 1>&2"
checkRedirectionToNumber _ t = case t of
T_IoFile id _ word -> potentially $ do
file <- getUnquotedLiteral word
guard $ all isDigit file
return $ warn id 2210 "This is a file redirection. Was it supposed to be a comparison or fd operation?"
_ -> return ()
return [] return []
runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |]) runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |])