7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-11-05 18:56:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

SC2164: show two possible variants for circumenting the warning

Browse Source 
always calling 'exit' is not good in e.g. functions.
the basic idea is at least that the returncode of
cd *is* evaluated somehow and not ignored.

Reported-by: Garance Alistair Drosehn <drosehn@rpi.edu>

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
This commit is contained in:
Bastian Bittorf
2017-01-10 12:30:47 +01:00
parent edb01fa855
commit 4e13c7cbc1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ShellCheck/Analytics.hs
View File

@@ -2514,7 +2514,7 @@ checkUncheckedCd params root =
when(t `isUnqualifiedCommand` "cd" when(t `isUnqualifiedCommand` "cd"
&& not (isCdDotDot t) && not (isCdDotDot t)
&& not (isCondition $ getPath (parentMap params) t)) $ && not (isCondition $ getPath (parentMap params) t)) $
warn (getId t) 2164 "Use cd ... || exit in case cd fails." warn (getId t) 2164 "Use 'cd ... || exit' or 'cd ... || return' in case cd fails."
checkElement _ = return () checkElement _ = return ()
isCdDotDot t = oversimplify t == ["cd", ".."] isCdDotDot t = oversimplify t == ["cd", ".."]
hasSetE = isNothing $ doAnalysis (guard . not . isSetE) root hasSetE = isNothing $ doAnalysis (guard . not . isSetE) root