7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use single quotes for the format string example in SC2059

This commit is contained in:
Vidar Holen 2019-10-24 10:33:17 -07:00
parent 60f75e5b8a
commit 4dfd7eb1cf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ShellCheck/Checks/Commands.hs
View File

@ -573,7 +573,7 @@ checkPrintfVar = CommandCheck (Exactly "printf") (f . arguments) where
unless ('%' `elem` concat (oversimplify format) || isLiteral format) $ unless ('%' `elem` concat (oversimplify format) || isLiteral format) $
info (getId format) 2059 info (getId format) 2059
"Don't use variables in the printf format string. Use printf \"..%s..\" \"$foo\"." "Don't use variables in the printf format string. Use printf '..%s..' \"$foo\"."
where where
onlyTrailingTs format argCount = onlyTrailingTs format argCount =
all (== 'T') $ drop argCount format all (== 'T') $ drop argCount format