Added warning for {1..$N}

This commit is contained in:
Vidar Holen 2012-11-08 21:55:24 -08:00
parent 7dbae12c7e
commit 38c5c6f847
1 changed files with 6 additions and 0 deletions

View File

@ -34,6 +34,7 @@ basicChecks = [
,checkUnquotedZN
,checkNumberComparisons
,checkNoaryWasBinary
,checkBraceExpansionVars
]
modifyMap = modify
@ -233,6 +234,11 @@ checkNoaryWasBinary (TC_Noary _ _ t@(T_NormalWord id l)) = do
when ('=' `elem` str) $ addNoteFor id $ Note ErrorC $ "Always true because you didn't put spaces around the ="
checkNoaryWasBinary _ = return ()
prop_checkBraceExpansionVars = verify checkBraceExpansionVars "echo {1..$n}"
checkBraceExpansionVars (T_BraceExpansion id s) | '$' `elem` s =
addNoteFor id $ Note WarningC $ "You can't use variables in brace expansions."
checkBraceExpansionVars _ = return ()
allModifiedVariables t = snd $ runState (doAnalysis (\x -> modify $ (++) (getModifiedVariables x)) t) []
--- Subshell detection