From 3785a08906b23e18d8299af458b93a2ec314b525 Mon Sep 17 00:00:00 2001
From: Vidar Holen <spam@vidarholen.net>
Date: Sun, 1 Oct 2017 10:26:16 -0700
Subject: [PATCH] Don't suggest $@ in [[ $* = "" ]] (#976)
---
ShellCheck/Analytics.hs | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs
index d6831c4..f524a87 100644
--- a/ShellCheck/Analytics.hs
+++ b/ShellCheck/Analytics.hs
@@ -635,13 +635,11 @@ checkShorthandIf _ _ = return ()
prop_checkDollarStar = verify checkDollarStar "for f in $*; do ..; done"
prop_checkDollarStar2 = verifyNot checkDollarStar "a=$*"
+prop_checkDollarStar3 = verifyNot checkDollarStar "[[ $* = 'a b' ]]"
checkDollarStar p t@(T_NormalWord _ [b@(T_DollarBraced id _)])
| bracedString b == "*" =
- unless isAssigned $
+ unless (isStrictlyQuoteFree (parentMap p) t) $
warn id 2048 "Use \"$@\" (with quotes) to prevent whitespace problems."
- where
- path = getPath (parentMap p) t
- isAssigned = any isAssignment . take 2 $ path
checkDollarStar _ _ = return ()