7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Get rid of our getOpt, as it already exists as lookup

This commit is contained in:
Joseph C. Sible 2020-02-01 22:50:13 -05:00
parent 2e52c2b56a
commit 3449e6be21
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ShellCheck/Analytics.hs
View File

@ -2840,7 +2840,7 @@ checkReadWithoutR _ t@T_SimpleCommand {} | t `isUnqualifiedCommand` "read" =
flags = getAllFlags t flags = getAllFlags t
has_t0 = fromMaybe False $ do has_t0 = fromMaybe False $ do
parsed <- getOpts flagsForRead flags parsed <- getOpts flagsForRead flags
t <- getOpt "t" parsed t <- lookup "t" parsed
str <- getLiteralString t str <- getLiteralString t
return $ str == "0" return $ str == "0"

2
src/ShellCheck/AnalyzerLib.hs
View File

@ -960,8 +960,6 @@ getOpts string flags = process flags
more <- process rest2 more <- process rest2
return $ (flag1, token1) : more return $ (flag1, token1) : more
getOpt str flags = snd <$> (listToMaybe $ filter (\(f, _) -> f == str) $ flags)
supportsArrays shell = shell == Bash || shell == Ksh supportsArrays shell = shell == Bash || shell == Ksh
-- Returns true if the shell is Bash or Ksh (sorry for the name, Ksh) -- Returns true if the shell is Bash or Ksh (sorry for the name, Ksh)