From 34259f16db6546f539538add7a8669bd275075f9 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Fri, 30 Nov 2012 14:32:20 -0800 Subject: [PATCH] Fixed message for (($1)) --- ShellCheck/Analytics.hs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index 4f2970e..d42ca90 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -439,8 +439,12 @@ prop_checkArithmeticDeref = verify checkArithmeticDeref "echo $((3+$foo))" prop_checkArithmeticDeref2 = verify checkArithmeticDeref "cow=14; (( s+= $cow ))" prop_checkArithmeticDeref3 = verifyNot checkArithmeticDeref "cow=1/40; (( s+= ${cow%%/*} ))" prop_checkArithmeticDeref4 = verifyNot checkArithmeticDeref "(( ! $? ))" -checkArithmeticDeref (TA_Expansion _ (T_DollarBraced id l)) | not $ any (`elem` "/.:#%?*@") $ bracedString l = +prop_checkArithmeticDeref5 = verifyNot checkArithmeticDeref "(($1))" +checkArithmeticDeref (TA_Expansion _ (T_DollarBraced id l)) | not . excepting $ bracedString l = style id $ "Don't use $ on variables in (( ))." + where + excepting [] = True + excepting s = (any (`elem` "/.:#%?*@") s) || (isDigit $ head s) checkArithmeticDeref _ = return ()