7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warning for dirname/basename

This commit is contained in:
Vidar Holen 2012-11-28 21:06:58 -08:00
parent 089537afed
commit 3308ac9173
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ShellCheck/Analytics.hs
View File

@ -70,7 +70,7 @@ basicChecks = [
,checkFindNameGlob ,checkFindNameGlob
,checkGrepRe ,checkGrepRe
,checkDollarArithmeticCommand ,checkDollarArithmeticCommand
,checkExpr ,checkNeedlessCommands
,checkQuotedCondRegex ,checkQuotedCondRegex
,checkForInCat ,checkForInCat
] ]
@ -180,10 +180,14 @@ checkUuoc (T_Pipeline _ (T_Redirecting _ _ f@(T_SimpleCommand id _ _):_:_)) =
_ -> return () _ -> return ()
checkUuoc _ = return () checkUuoc _ = return ()
prop_checkExpr = verify checkExpr "foo=$(expr 3 + 2)" prop_checkNeedlessCommands = verify checkNeedlessCommands "foo=$(expr 3 + 2)"
checkExpr (T_SimpleCommand id _ (w:_)) | w `isCommand` "expr" = checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "expr" =
style id "Use $((..)), ${} or [[ ]] in place of antiquated expr." style id "Use $((..)), ${} or [[ ]] in place of antiquated expr."
checkExpr _ = return () checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "dirname" =
style id "Use parameter expansion instead, such as ${var%/*}."
checkNeedlessCommands (T_SimpleCommand id _ (w:_)) | w `isCommand` "basename" =
style id "Use parameter expansion instead, such as ${var##*/}."
checkNeedlessCommands _ = return ()
prop_checkPipePitfalls1 = verify checkPipePitfalls "foo | grep foo | awk bar" prop_checkPipePitfalls1 = verify checkPipePitfalls "foo | grep foo | awk bar"
prop_checkPipePitfalls2 = verifyNot checkPipePitfalls "foo | awk bar | grep foo" prop_checkPipePitfalls2 = verifyNot checkPipePitfalls "foo | awk bar | grep foo"