7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-08-07 20:23:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improved messages for missing spaces in [..]

Browse Source
This commit is contained in:
Vidar Holen
2013-07-10 23:03:42 -07:00
parent 5a3493740e
commit 2214889a36
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ShellCheck/Parser.hs
View File

@@ -268,8 +268,6 @@ readConditionContents single = do
x <- readNormalWord x <- readNormalWord
pos <- getPosition pos <- getPosition
when (endedWith "]" x) $ do when (endedWith "]" x) $ do
lookAhead (try $
(many whitespace) >> (eof <|> disregard readSeparator <|> disregard (g_Then <|> g_Do)))
parseProblemAt pos ErrorC $ parseProblemAt pos ErrorC $
"You need a space before the " ++ (if single then "]" else "]]") ++ "." "You need a space before the " ++ (if single then "]" else "]]") ++ "."
when (single && endedWith ")" x) $ do when (single && endedWith ")" x) $ do
@@ -305,8 +303,8 @@ readConditionContents single = do
pos <- getPosition pos <- getPosition
lookAhead (char '[') lookAhead (char '[')
parseProblemAt pos ErrorC $ if single parseProblemAt pos ErrorC $ if single
then "Don't use [] for grouping. Use \\( .. \\)." then "If grouping expressions inside [..], use \\( ..\\)."
else "Don't use [] for grouping. Use ()." else "If grouping expressions inside [[..]], use ( .. )."
) )
(do (do
pos <- getPosition pos <- getPosition