7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify findFunction

This commit is contained in:
Joseph C. Sible 2020-02-09 21:08:32 -05:00
parent 172aa7c4fc
commit 21ad4196db
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ShellCheck/Analytics.hs
View File

@ -2488,12 +2488,10 @@ checkUnpassedInFunctions params root =
map (\t@(T_Function _ _ _ name _) -> (name,t)) functions map (\t@(T_Function _ _ _ name _) -> (name,t)) functions
functions = execWriter $ doAnalysis (tell . maybeToList . findFunction) root functions = execWriter $ doAnalysis (tell . maybeToList . findFunction) root
findFunction t@(T_Function id _ _ name body) = findFunction t@(T_Function id _ _ name body)
let flow = getVariableFlow params body | any (isPositionalReference t) flow && not (any isPositionalAssignment flow)
in = return t
if any (isPositionalReference t) flow && not (any isPositionalAssignment flow) where flow = getVariableFlow params body
then return t
else Nothing
findFunction _ = Nothing findFunction _ = Nothing
isPositionalAssignment x = isPositionalAssignment x =