7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make ShellCheck not emit warnings about the shebang if the shell 

type is determined from the extension
This commit is contained in:
Tito Sacchi 2019-01-14 14:25:01 +01:00
parent a4b9cec9f0
commit 1e6a30905a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ShellCheck/Analytics.hs
View File

@ -484,7 +484,7 @@ checkShebang params (T_Annotation _ list t) =
checkShebang params (T_Script id sb _) = execWriter $ do checkShebang params (T_Script id sb _) = execWriter $ do
unless (shellTypeSpecified params) $ do unless (shellTypeSpecified params) $ do
when (sb == "") $ when (sb == "") $
err id 2148 "Tips depend on target shell and yours is unknown. Add a shebang." err id 2148 "Tips depend on target shell and yours is unknown. Add a shebang or an extension to the filename."
when (executableFromShebang sb == "ash") $ when (executableFromShebang sb == "ash") $
warn id 2187 "Ash scripts will be checked as Dash. Add '# shellcheck shell=dash' to silence." warn id 2187 "Ash scripts will be checked as Dash. Add '# shellcheck shell=dash' to silence."
unless (null sb) $ do unless (null sb) $ do

2
src/ShellCheck/AnalyzerLib.hs
View File

@ -184,7 +184,7 @@ makeParameters spec =
Sh -> False Sh -> False
Ksh -> True, Ksh -> True,
shellTypeSpecified = isJust $ asShellType spec, shellTypeSpecified = isJust (asShellType spec) || isJust (asFallbackShell spec),
parentMap = getParentTree root, parentMap = getParentTree root,
variableFlow = getVariableFlow params root, variableFlow = getVariableFlow params root,
tokenPositions = asTokenPositions spec tokenPositions = asTokenPositions spec