From 1e32139f6618953d60ce81860a3319062c92129b Mon Sep 17 00:00:00 2001 From: "Joseph C. Sible" Date: Sun, 9 Feb 2020 19:18:43 -0500 Subject: [PATCH] Replace mapMaybe and concatMap with list comprehensions --- src/ShellCheck/Analytics.hs | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/ShellCheck/Analytics.hs b/src/ShellCheck/Analytics.hs index 8a2902c..c58e97a 100644 --- a/src/ShellCheck/Analytics.hs +++ b/src/ShellCheck/Analytics.hs @@ -87,13 +87,8 @@ runList spec list = notes getEnableDirectives root = case root of - T_Annotation _ list _ -> mapMaybe getEnable list + T_Annotation _ list _ -> [s | EnableComment s <- list] _ -> [] - where - getEnable t = - case t of - EnableComment s -> return s - _ -> Nothing checkList l t = concatMap (\f -> f t) l @@ -3123,9 +3118,7 @@ checkUnmatchableCases params t = Just l -> " on line " <> show l <> "." _ -> "." - valids = concatMap f rest - f (x, Just y) = [(x,y)] - f _ = [] + valids = [(x,y) | (x, Just y) <- rest] checkDoms _ = return ()