7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-08-08 18:25:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improved regex parsing. To think [[ f =~ f( ]] )* ]] is valid..

Browse Source
This commit is contained in:
Vidar Holen
2013-05-28 21:32:15 -07:00
parent 6b89f33d0c
commit 1dbbc51f86
2 changed files with 33 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ShellCheck/Analytics.hs
View File

@@ -155,6 +155,7 @@ isGlob _ = False
isConfusedGlobRegex ('*':_) = True
isConfusedGlobRegex [x,'*'] | x /= '\\' = True
isConfusedGlobRegex _ = False
isPotentiallyConfusedGlobRegex =
@@ -588,10 +589,10 @@ prop_checkGlobbedRegex2a = verify checkGlobbedRegex "[[ $foo =~ \\#* ]]"
prop_checkGlobbedRegex3 = verifyNot checkGlobbedRegex "[[ $foo =~ $foo ]]"
prop_checkGlobbedRegex4 = verifyNot checkGlobbedRegex "[[ $foo =~ ^c.* ]]"
checkGlobbedRegex (TC_Binary _ DoubleBracket "=~" _ rhs) =
case rhs of
T_NormalWord id ((T_Glob _ "*"):_) -> warn id $ "=~ is for regex. Use == for globs."
T_NormalWord id ([(T_Literal _ [c]), (T_Glob _ "*")]) -> warn id $ "=~ is for regex. Either ^anchor$ this, or treat it as a glob with == ."
_ -> return ()
let s = concat $ deadSimple rhs in
if isConfusedGlobRegex s
then warn (getId rhs) $ "=~ is for regex. Use == for globs."
else return ()
checkGlobbedRegex _ = return ()