From 1af23fd131dacd5fca185e0ad7c9684bc3983486 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Sun, 25 May 2014 11:41:24 -0700 Subject: [PATCH] Fix SC2051 to only warn about 1..$n and not 1,$n --- ShellCheck/Analytics.hs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index d68617e..d2ccac3 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -1140,9 +1140,10 @@ checkConstantNoary _ (TC_Noary _ _ t@(T_NormalWord id _)) | isConstant t = do err id 2078 $ "This expression is constant. Did you forget a $ somewhere?" checkConstantNoary _ _ = return () -prop_checkBraceExpansionVars = verify checkBraceExpansionVars "echo {1..$n}" -checkBraceExpansionVars _ (T_BraceExpansion id s) | '$' `elem` s = - warn id 2051 $ "Bash doesn't support variables in brace expansions." +prop_checkBraceExpansionVars1 = verify checkBraceExpansionVars "echo {1..$n}" +prop_checkBraceExpansionVars2 = verifyNot checkBraceExpansionVars "echo {1,3,$n}" +checkBraceExpansionVars _ (T_BraceExpansion id s) | "..$" `isInfixOf` s = + warn id 2051 $ "Bash doesn't support variables in brace range expansions." checkBraceExpansionVars _ _ = return () prop_checkForDecimals = verify checkForDecimals "((3.14*c))"