7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make SC2141 trigger more broadly

This commit is contained in:
Vidar Holen 2020-02-01 16:51:40 -08:00
parent ff5f29f661
commit 1696296c0a
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/ShellCheck/Analytics.hs
View File

@ -2651,21 +2651,25 @@ checkMultipleAppends params t =
prop_checkSuspiciousIFS1 = verify checkSuspiciousIFS "IFS=\"\\n\"" prop_checkSuspiciousIFS1 = verify checkSuspiciousIFS "IFS=\"\\n\""
prop_checkSuspiciousIFS2 = verifyNot checkSuspiciousIFS "IFS=$'\\t'" prop_checkSuspiciousIFS2 = verifyNot checkSuspiciousIFS "IFS=$'\\t'"
checkSuspiciousIFS params (T_Assignment id Assign "IFS" [] value) = prop_checkSuspiciousIFS3 = verify checkSuspiciousIFS "IFS=' \\t\\n'"
checkSuspiciousIFS params (T_Assignment _ _ "IFS" [] value) =
potentially $ do potentially $ do
str <- getLiteralString value str <- getLiteralString value
return $ check str return $ check str
where where
n = if shellType params == Sh then "'<literal linefeed here>'" else "$'\\n'" hasDollarSingle = shellType params == Bash || shellType params == Ksh
t = if shellType params == Sh then "\"$(printf '\\t')\"" else "$'\\t'" n = if hasDollarSingle then "$'\\n'" else "'<literal linefeed here>'"
t = if hasDollarSingle then "$'\\t'" else "\"$(printf '\\t')\""
check value = check value =
case value of case value of
"\\n" -> suggest n "\\n" -> suggest n
"/n" -> suggest n
"\\t" -> suggest t "\\t" -> suggest t
"/t" -> suggest t x | '\\' `elem` x -> suggest2 "a literal backslash"
x | 'n' `elem` x -> suggest2 "the literal letter 'n'"
x | 't' `elem` x -> suggest2 "the literal letter 't'"
_ -> return () _ -> return ()
suggest r = warn id 2141 $ "Did you mean IFS=" ++ r ++ " ?" suggest r = warn (getId value) 2141 $ "This backslash is literal. Did you mean IFS=" ++ r ++ " ?"
suggest2 desc = warn (getId value) 2141 $ "This IFS value contains " ++ desc ++ ". For tabs/linefeeds/escapes, use $'..', literal, or printf."
checkSuspiciousIFS _ _ = return () checkSuspiciousIFS _ _ = return ()