From 13d4ea6540f9eb2e3ade96cb85011d1be63b88f6 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Mon, 20 May 2013 11:58:08 -0700 Subject: [PATCH] Don't complaing about lack of quotes for 'local' and 'declare' --- ShellCheck/Analytics.hs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index 0555dc5..af846a7 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -698,7 +698,7 @@ inUnquotableContext tree t = TA_Trinary _ _ _ _ -> True TA_Expansion _ _ -> True T_Assignment _ _ _ -> True - T_Redirecting _ _ _ -> False + T_Redirecting _ _ _ -> or $ map (isCommand t) ["local", "declare"] T_DoubleQuoted _ _ -> True T_CaseExpression _ _ _ -> True T_ForIn _ _ _ _ -> True -- Pragmatically assume it's desirable here @@ -1033,6 +1033,9 @@ prop_checkSpacefulnessB = verifyFull checkSpacefulness "rm ${10//foo/bar}" prop_checkSpacefulnessC = verifyNotFull checkSpacefulness "(( $1 + 3 ))" prop_checkSpacefulnessD = verifyNotFull checkSpacefulness "if [[ $2 -gt 14 ]]; then true; fi" prop_checkSpacefulnessE = verifyNotFull checkSpacefulness "foo=$3 env" +prop_checkSpacefulnessF = verifyNotFull checkSpacefulness "local foo=$1" +prop_checkSpacefulnessG = verifyNotFull checkSpacefulness "declare foo=$1" +prop_checkSpacefulnessH = verifyFull checkSpacefulness "echo foo=$1" checkSpacefulness t = let (_, (newMetaMap, spaceMap)) = runState (doStackAnalysis startScope endScope t) ([], Map.empty)