7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update gallery of bad code

This commit is contained in:
Vidar Holen 2018-04-28 12:58:44 -07:00
parent bb4ce86fab
commit 12b3fdf661
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
README.md
View File

@ -301,6 +301,7 @@ alias archive='mv $1 /backup' # Defining aliases with arguments
tr -cd '[a-zA-Z0-9]' # [] around ranges in tr tr -cd '[a-zA-Z0-9]' # [] around ranges in tr
exec foo; echo "Done!" # Misused 'exec' exec foo; echo "Done!" # Misused 'exec'
find -name \*.bak -o -name \*~ -delete # Implicit precedence in find find -name \*.bak -o -name \*~ -delete # Implicit precedence in find
# find . -exec foo > bar \; # Redirections in find
f() { whoami; }; sudo f # External use of internal functions f() { whoami; }; sudo f # External use of internal functions
``` ```
@ -316,9 +317,13 @@ var$n="Hello" # Wrong indirect assignment
echo ${var$n} # Wrong indirect reference echo ${var$n} # Wrong indirect reference
var=(1, 2, 3) # Comma separated arrays var=(1, 2, 3) # Comma separated arrays
array=( [index] = value ) # Incorrect index initialization array=( [index] = value ) # Incorrect index initialization
echo $var[14] # Missing {} in array references
echo "Argument 10 is $10" # Positional parameter misreference echo "Argument 10 is $10" # Positional parameter misreference
if $(myfunction); then ..; fi # Wrapping commands in $() if $(myfunction); then ..; fi # Wrapping commands in $()
else if othercondition; then .. # Using 'else if' else if othercondition; then .. # Using 'else if'
f; f() { echo "hello world; } # Using function before definition
[ false ] # 'false' being true
if ( -f file ) # Using (..) instead of test
``` ```
### Style ### Style
@ -349,6 +354,8 @@ printf "%s\n" "Arguments: $@." # Concatenating strings and arrays
var=World; echo "Hello " var # Unused lowercase variables var=World; echo "Hello " var # Unused lowercase variables
echo "Hello $name" # Unassigned lowercase variables echo "Hello $name" # Unassigned lowercase variables
cmd | read bar; echo $bar # Assignments in subshells cmd | read bar; echo $bar # Assignments in subshells
cat foo | cp bar # Piping to commands that don't read
printf '%s: %s\n' foo # Mismatches in printf argument count
``` ```
### Robustness ### Robustness
@ -362,6 +369,7 @@ find . -exec sh -c 'a && b {}' \; # Find -exec shell injection
printf "Hello $name" # Variables in printf format printf "Hello $name" # Variables in printf format
for f in $(ls *.txt); do # Iterating over ls output for f in $(ls *.txt); do # Iterating over ls output
export MYVAR=$(cmd) # Masked exit codes export MYVAR=$(cmd) # Masked exit codes
case $version in 2.*) :;; 2.6.*) # Shadowed case branches
``` ```
### Portability ### Portability
@ -396,6 +404,7 @@ var=42 echo $var # Expansion of inlined environment
echo $((n/180*100)) # Unnecessary loss of precision echo $((n/180*100)) # Unnecessary loss of precision
ls *[:digit:].txt # Bad character class globs ls *[:digit:].txt # Bad character class globs
sed 's/foo/bar/' file > file # Redirecting to input sed 's/foo/bar/' file > file # Redirecting to input
while getopts "a" f; do case $f in "b") # Unhandled getopts flags
``` ```
## Testimonials ## Testimonials
@ -430,6 +439,6 @@ The contributor retains the copyright.
ShellCheck is licensed under the GNU General Public License, v3. A copy of this license is included in the file [LICENSE](LICENSE). ShellCheck is licensed under the GNU General Public License, v3. A copy of this license is included in the file [LICENSE](LICENSE).
Copyright 2012-2015, Vidar 'koala_man' Holen and contributors. Copyright 2012-2018, Vidar 'koala_man' Holen and contributors.
Happy ShellChecking! Happy ShellChecking!