From 29dedbdc9ceb47057bb275d26b5747c976522372 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20Adri=C3=A1n=20Ontivero?= Date: Fri, 28 Dec 2018 20:55:52 -0300 Subject: [PATCH] Fix 'export -p' being undefined under POSIX sh Fixes #1432 --- src/ShellCheck/Checks/ShellSupport.hs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ShellCheck/Checks/ShellSupport.hs b/src/ShellCheck/Checks/ShellSupport.hs index 204c641..4935c05 100644 --- a/src/ShellCheck/Checks/ShellSupport.hs +++ b/src/ShellCheck/Checks/ShellSupport.hs @@ -141,6 +141,8 @@ prop_checkBashisms58= verify checkBashisms "#!/bin/sh\nulimit -c 0" prop_checkBashisms59 = verify checkBashisms "#!/bin/sh\njobs -s" prop_checkBashisms60 = verifyNot checkBashisms "#!/bin/sh\njobs -p" prop_checkBashisms61 = verifyNot checkBashisms "#!/bin/sh\njobs -lp" +prop_checkBashisms62 = verify checkBashisms "#!/bin/sh\nexport -f foo" +prop_checkBashisms63 = verifyNot checkBashisms "#!/bin/sh\nexport -p" checkBashisms = ForShell [Sh, Dash] $ \t -> do params <- ask @@ -286,7 +288,7 @@ checkBashisms = ForShell [Sh, Dash] $ \t -> do ] ++ if not isDash then ["local"] else [] allowedFlags = Map.fromList [ ("exec", []), - ("export", ["-p"]), + ("export", ["p"]), ("jobs", ["l", "p"]), ("printf", []), ("read", if isDash then ["r", "p"] else ["r"]),