7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warnings for unquoted positional parameters

This commit is contained in:
Vidar Holen 2012-11-05 19:00:40 -08:00
parent ce46defec8
commit 0c0b386cf3
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Shpell/Analytics.hs
View File

@ -4,6 +4,7 @@ import Shpell.Parser
import Control.Monad import Control.Monad
import Control.Monad.State import Control.Monad.State
import qualified Data.Map as Map import qualified Data.Map as Map
import Data.Char
import Data.List import Data.List
import Debug.Trace import Debug.Trace
@ -27,6 +28,7 @@ basicChecks = [
,checkDollarStar ,checkDollarStar
,checkUnquotedDollarAt ,checkUnquotedDollarAt
,checkStderrRedirect ,checkStderrRedirect
,checkMissingPositionalQuotes
] ]
modifyMap = modify modifyMap = modify
@ -112,6 +114,14 @@ checkMissingForQuotes (T_ForIn _ f words cmds) =
warning id = addNoteFor id $ Note WarningC $ "Variables that could contain spaces should be quoted" warning id = addNoteFor id $ Note WarningC $ "Variables that could contain spaces should be quoted"
checkMissingForQuotes _ = return () checkMissingForQuotes _ = return ()
prop_checkMissingPositionalQuotes = verify checkMissingPositionalQuotes "rm $1"
prop_checkMissingPositionalQuotes2 = verify checkMissingPositionalQuotes "rm ${10//foo/bar}"
checkMissingPositionalQuotes (T_NormalWord _ list) =
mapM_ checkPos list
where checkPos (T_DollarBraced id s) | all isDigit (getBracedReference s) =
addNoteFor id $ Note WarningC $ "Positional parameters should be quoted to avoid whitespace trouble"
checkPos _ = return ()
checkMissingPositionalQuotes _ = return ()
prop_checkUnquotedExpansions = verify checkUnquotedExpansions "rm $(ls)" prop_checkUnquotedExpansions = verify checkUnquotedExpansions "rm $(ls)"
checkUnquotedExpansions (T_SimpleCommand _ _ cmds) = mapM_ check cmds checkUnquotedExpansions (T_SimpleCommand _ _ cmds) = mapM_ check cmds